Makefile: add more platforms to Makefile #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xynnn007
approved these changes
Jan 3, 2024
mkulke
approved these changes
Jan 3, 2024
It is always build by default. We might want to have a flag for nothing else to be built. I'm not sure if we support that. |
fitzthum
force-pushed
the
update-makefile
branch
from
083df69 to
743ee8c
Compare
|
Ok, I will probably create another PR to enable building only the sample attester. Currently we don't quite have the option to do that. To be clear what we can do currently is build the AA with |
fitzthum
force-pushed
the
update-makefile
branch
2 times, most recently
from
46776bb to
b8fc742
Compare
|
Actually it was a 2-line fix, so I added it here. Now we can build only the cc_kbc with sample attester with |
Adds SNP, AZ-SNP-vTPM, and AZ-TDX-vTPM to the top-level Makefile. Also changes the name of the offline_fs_kbc flag to fs rather than test. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
fitzthum
force-pushed
the
update-makefile
branch
from
b8fc742 to
8bc3f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SNP, AZ-SNP-vTPM, and AZ-TDX-vTPM to the
top-level Makefile.
@mkulke can you double-check that I did the AZ features correctly?
Also changes the name of the offline_fs_kbc flag
to fs rather than test. See confidential-containers/confidential-containers#184 for reasoning behind this change.